fix(archiver): swallow error when rollup contract not yet finalized on L1#22156
Merged
spalladino merged 1 commit intomerge-train/spartanfrom Mar 30, 2026
Merged
Conversation
…n L1 Right after deployment, querying getProvenCheckpointNumber at the finalized L1 block fails because the contract didn't exist yet at that block. This is expected and should not log a warning. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
alexghr
approved these changes
Mar 30, 2026
AztecBot
pushed a commit
that referenced
this pull request
Mar 30, 2026
…n L1 (#22156) ## Motivation Right after deployment, the archiver's L1 sync queries `getProvenCheckpointNumber` at the finalized L1 block tag. But if the rollup contract didn't exist yet at that L1 block, the call returns no data and logs a noisy warning on every sync iteration. ## Approach Swallow the "returned no data" error in `updateFinalizedCheckpoint` since it's an expected transient condition. Other errors still log a warning. ## Changes - **archiver**: Silence the `ContractFunctionExecutionError` with "returned no data" in `updateFinalizedCheckpoint`, which occurs when the rollup contract is too new to exist at the finalized L1 block Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
✅ Successfully backported to backport-to-v4-next-staging #22158. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 30, 2026
BEGIN_COMMIT_OVERRIDE chore: setup snapshot retention rules (#22107) fix: add branding to Buffer16 and Buffer32 to prevent cross-type misuse (#22128) chore: (A-723) redact beacon api key in debug path (#22115) fix(archiver): use Buffer16.ZERO for rolling hash fallback in L1 synchronizer (#22133) feat(pipeline): allow syncing blocks ontop of the proposed chain (#21025) fix(logger): no arbitrary long logger module name (#22143) chore: setup workload identity for ESO (#22137) fix: Make test more robust to committee selection. (#22139) fix: handle error event on SSH agent socket to prevent Node crash (#22090) fix: disable SponsoredFPC on staging-public (#22150) fix(archiver): swallow error when rollup contract not yet finalized on L1 (#22156) chore: update dashboard (#22157) chore: switch testnet back to prod resource profile (#22159) chore: nightly scenario deployments should not be triggered by older images (#22148) END_COMMIT_OVERRIDE
AztecBot
added a commit
that referenced
this pull request
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Right after deployment, the archiver's L1 sync queries
getProvenCheckpointNumberat the finalized L1 block tag. But if the rollup contract didn't exist yet at that L1 block, the call returns no data and logs a noisy warning on every sync iteration.Approach
Swallow the "returned no data" error in
updateFinalizedCheckpointsince it's an expected transient condition. Other errors still log a warning.Changes
ContractFunctionExecutionErrorwith "returned no data" inupdateFinalizedCheckpoint, which occurs when the rollup contract is too new to exist at the finalized L1 block