Conversation
This is a breaking change in the interface between PXE and wallets. ALL_SCOPES allowed wallets to request PXE to run operations "for all its known accounts". This PR removes that option and forces all layers of the system to explicitly state which addresses to use as scope by providing an array of addresses. An empty array now means "no account in scope" (it used to default to "ALL_SCOPES" particularly when executing utilities).
Collaborator
Author
|
🤖 Auto-merge enabled after 4 hours of inactivity. This PR will be merged automatically once all checks pass. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Currently the `ORACLE_VERSION` on `v4-next` is 22 but on `merge-train/fairies` it's 21. I think this has accidentally happened when backporting as it should never happen that code on v4-next is ahead of v5 (the version was bumped in [this commit](a0cbbb6) on v4-next). For this reason I am bumping the version here to 22 as I could imagine it could cause issues. Co-authored-by: benesjan <benesjan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat!: remove ALL_SCOPES (#22136)
chore: syncing oracle versions (#22131)
fix(aztec-nr): use registered accounts as capsule test scopes (#22171)
chore: reverting accidentally merged AI slop (#22175)
END_COMMIT_OVERRIDE