Skip to content

fix: run compatibility tests on all v4-related branches#22149

Merged
alexghr merged 1 commit intonextfrom
claudebox/audit-compat-tests-ci
Mar 30, 2026
Merged

fix: run compatibility tests on all v4-related branches#22149
alexghr merged 1 commit intonextfrom
claudebox/audit-compat-tests-ci

Conversation

@AztecBot
Copy link
Copy Markdown
Collaborator

Summary

The testnet_compatibility and mainnet_compatibility tests were only running on PRs targeting branches matching ^v[0-9]+$ (e.g. v4). This missed three other critical branches:

  • backport-to-v4-staging
  • v4-next
  • backport-to-v4-next

This caused a compatibility break on staging-public (4.2.0-aztecnr.2 bricking nodes due to block header shape changes between 4.1 and 4.2) to go undetected.

Fix

Expanded the regex in yarn-project/bootstrap.sh to:

^(v[0-9]+(-next)?|backport-to-v[0-9]+-(staging|next))$

This matches all four required branch patterns while still excluding next, master, and other non-release branches.

ClaudeBox log: https://claudebox.work/s/dd9d82043dbc175f?run=1

The regex for triggering testnet_compatibility and mainnet_compatibility
tests only matched branches like 'v4' (^v[0-9]+$). This missed PRs
targeting backport-to-v4-staging, v4-next, and backport-to-v4-next.

Expanded the regex to match all four branch patterns.
@AztecBot AztecBot added ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR. labels Mar 30, 2026
@alexghr alexghr marked this pull request as ready for review March 30, 2026 15:04
@alexghr alexghr enabled auto-merge March 30, 2026 15:04
@alexghr alexghr added this pull request to the merge queue Mar 30, 2026
Merged via the queue into next with commit 694f604 Mar 30, 2026
44 of 52 checks passed
@alexghr alexghr deleted the claudebox/audit-compat-tests-ci branch March 30, 2026 15:54
AztecBot pushed a commit that referenced this pull request Mar 30, 2026
## Summary

The `testnet_compatibility` and `mainnet_compatibility` tests were only
running on PRs targeting branches matching `^v[0-9]+$` (e.g. `v4`). This
missed three other critical branches:

- `backport-to-v4-staging`
- `v4-next`
- `backport-to-v4-next`

This caused a compatibility break on staging-public (4.2.0-aztecnr.2
bricking nodes due to block header shape changes between 4.1 and 4.2) to
go undetected.

## Fix

Expanded the regex in `yarn-project/bootstrap.sh` to:
```
^(v[0-9]+(-next)?|backport-to-v[0-9]+-(staging|next))$
```

This matches all four required branch patterns while still excluding
`next`, `master`, and other non-release branches.

ClaudeBox log: https://claudebox.work/s/dd9d82043dbc175f?run=1
@AztecBot
Copy link
Copy Markdown
Collaborator Author

✅ Successfully backported to backport-to-v4-staging #22155.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-to-v4 ci-draft Run CI on draft PRs. claudebox Owned by claudebox. it can push to this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants