fix: bounds check in GateSeparatorPolynomial for virtual sumcheck rounds#22146
Draft
AztecBot wants to merge 1 commit intomerge-train/barretenbergfrom
Draft
fix: bounds check in GateSeparatorPolynomial for virtual sumcheck rounds#22146AztecBot wants to merge 1 commit intomerge-train/barretenbergfrom
AztecBot wants to merge 1 commit intomerge-train/barretenbergfrom
Conversation
AztecBot
added
ci-draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the fix from #22130 (targeting
next) tomerge-train/barretenberg.GateSeparatorPolynomial::current_element()andunivariate_eval()accessedbetas[current_element_idx]without bounds checking. During virtual sumcheck rounds (whencurrent_element_idx >= betas.size()), this read out-of-bounds heap memory, causing non-deterministic debug build assertion failures:The fix returns
FF(1)when past the betas array, which is mathematically correct since virtual rounds have no additional beta challenges.Full analysis: https://gist.github.com/AztecBot/909e3998f506b0dd6d07a211841dbeb8
ClaudeBox log: https://claudebox.work/s/39dda16ff88b644f?run=1