Skip to content

fix: sumcheck unit test causing UB #22130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iakovenkos merged 3 commits into from
Apr 1, 2026
Merged

fix: sumcheck unit test causing UB #22130

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b752c68
fix: bounds check in GateSeparatorPolynomial for virtual sumcheck rounds
AztecBot Mar 30, 2026
e3801bc
fix the test instead of gate separator changes
iakovenkos Apr 1, 2026
b3107d9
Merge branch 'merge-train/barretenberg' into claudebox/fix-bb-debug-b…
iakovenkos Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions barretenberg/cpp/src/barretenberg/sumcheck/sumcheck.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,11 +185,8 @@ template <typename Flavor> class SumcheckTests : public ::testing::Test {

FF alpha = transcript->template get_challenge<FF>("Sumcheck:alpha");

std::vector<FF> gate_challenges(multivariate_d);
for (size_t idx = 0; idx < gate_challenges.size(); idx++) {
gate_challenges[idx] =
transcript->template get_challenge<FF>("Sumcheck:gate_challenge_" + std::to_string(idx));
}
auto gate_challenges =
transcript->template get_dyadic_powers_of_challenge<FF>("Sumcheck:gate_challenge", CONST_PROOF_SIZE_LOG_N);

SumcheckProver<Flavor> sumcheck(
multivariate_n, full_polynomials, transcript, alpha, gate_challenges, {}, CONST_PROOF_SIZE_LOG_N);
Expand Down
Loading