-
Notifications
You must be signed in to change notification settings - Fork 592
feat: add RPC endpoints to manipulate time #22084
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
benesjan
wants to merge
8
commits into
merge-train/fairies
Choose a base branch
from
jan/f-407-add-an-rpc-endpoint-to-manipulate-time
base: merge-train/fairies
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
4ccf5a7
sketching timetravel rpc
nventuro 471ff1f
compilation fixes and readability improvements
benesjan 13792be
wip
benesjan a4ab47b
erroring out if current slot is less than lat block slot
benesjan f9dc604
cleanup
benesjan f480d54
wip
benesjan 2a96415
fixes
benesjan b715407
AztecNodeDebug
benesjan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code is quite foreign to me so I asked this to AI:
so this seems reasonable.
If the debug interface got accidentally exposed in prod in its current form then there would not be much damage to do as the function would error out with the warping methods but anyway there is a danger of us adding more powerful methods on the interface, then accidentally exposing this in prod and then bad things happening.
Do you think we should somehow guardrail this more such that via some code changes we don't accidentally expose this?