Remove the link between creators and parent handlers#158
Remove the link between creators and parent handlers#158CodeDrivenMitch wants to merge 1 commit intomainfrom
Conversation
…odd to some customers. References now show the method signature (and sometimes line number).
CodeDrivenMitch
requested review from
a team,
gklijs and
smcvb
and removed request for
a team
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
Bunch of questions to better understand what's happening here. Not blocking right now, as I am just not familiar enough with it at this stage.
| ENTITY_ID("org.axonframework.modelling.command.EntityId"), | ||
| PROCESSING_GROUP("org.axonframework.config.ProcessingGroup") | ||
| PROCESSING_GROUP("org.axonframework.config.ProcessingGroup"), | ||
| SAGA("org.axonframework.config.ProcessingGroup") |
There was a problem hiding this comment.
Shouldn't this refer to the sage annotation instead?
There was a problem hiding this comment.
Furthermore, what does this change have to do with the PR's intent of removing the link between creators and parent handlers?
| override val element: PsiElement, | ||
| override val payload: String, | ||
| override val parentHandler: Handler?, | ||
| val isDeadline: Boolean = false, |
There was a problem hiding this comment.
This PR now seems to implement more than just removal of linked parent handlers to creators. Was that intended?
| override val element: PsiElement, | ||
| override val payload: String, | ||
| override val parentHandler: Handler?, | ||
| val isDeadline: Boolean = false, |
There was a problem hiding this comment.
Regardless of the previous answer, having something called "default message creator" have a concept of whether it's a deadline makes it less default to me. I'd more so think you'd be dealing with a specific DeadlineMessageCreator in this case.
| return AxonNavigationGutterIconRenderer( | ||
| icon = AxonIcons.Axon, | ||
| popupTitle = "Axon References To This Class", | ||
| popupTitle = "Axon References To $qualifiedName", |
There was a problem hiding this comment.
This seems like a bug fix you've sneaked into this PR.
| * Searches for any event handlers that are not part of the aggregate model. | ||
| * | ||
| * @see org.axonframework.intellij.ide.plugin.handlers.types.EventHandler | ||
| * @see org.axonframework.intellij.ide.plugin.resolving.handlers.types.EventHandler |
There was a problem hiding this comment.
This seems like a documentation fix you've sneaked into this PR.
|
|
||
| override fun renderText(): String { | ||
| return "${element.containingClassname()}.${element.name}" | ||
| return element.toViewText() |
There was a problem hiding this comment.
I am certainly not deep enough into this stuff to understand how this solves the predicament of this PR. Would you care to explain this?
| } else toPackageName() | ||
| } | ||
|
|
||
| fun PsiMethod.toViewText(): String { |
There was a problem hiding this comment.
Ah, you've just 'generified' the entire naming scheme. This makes sense.
| assertThat(hasLineMarker(DeadlineHandlerMethodLineMarkerProvider::class.java)).isTrue | ||
| assertThat(getLineMarkerOptions(DeadlineHandlerMethodLineMarkerProvider::class.java)).containsExactly( | ||
| OptionSummary("MyCommand", null, AxonIcons.Publisher) | ||
| OptionSummary("MyAggregate.handle(MyCommand, DeadlineManager):${actualLineNumber(9)}", "my_special_deadline", AxonIcons.Publisher) |
There was a problem hiding this comment.
I guess it's the toViewText method you've added, causing the line number to be added, but I don't clearly see how. Would you mind elaborating on this?
2 participants
Remove the link between creators and parent handlers since they were odd to some customers.
References now show the method signature (and sometimes line number).