axdynamicbar: larger touch targets for keyguard media controls - #60
Closed
zedisspp wants to merge 3 commits into
Closed
axdynamicbar: larger touch targets for keyguard media controls#60zedisspp wants to merge 3 commits into
zedisspp wants to merge 3 commits into
Conversation
Increase size and spacing of the prev/play-pause/next buttons in the keyguard media pill, since the previous touch targets were too small and easy to mis-tap. - Add dedicated MediaActionSize/MediaActionIconSize/ MediaPlayPauseSize tokens, used only by the media chip so other chip types (timer, recording, sports, etc.) keep their existing ActionSize/ActionIconSize. - Grow the pill height slightly for IslandEvent.Media so the larger buttons fit without crowding the track text. - Swap the solid background fill for a translucent one with a subtle border for a glass-style look.
Give the media chip its own size tokens instead of sharing values with other chip types, and replace the semi-transparent background/border with the standard accent fill. Move playback controls below the track/artist text instead of inline, and switch album art to a circular shape.
Replace Arrangement.SpaceBetween with Arrangement.spacedBy(SpaceLg, Alignment.CenterHorizontally) in the media controls Row (skip prev / play-pause / skip next) of AxDynamicBarKeyguardChip. SpaceBetween pushed the buttons to the edges of the Row, which inherits the full chip width (up to MediaChipMaxWidth), leaving a large gap in the middle. spacedBy sets a fixed, controlled gap and centers the buttons regardless of chip width.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase size and spacing of the prev/play-pause/next buttons in the keyguard media pill, since the previous touch targets were too small and easy to mis-tap.