Conversation
|
ardox if you're running out of patience I understand lmao |
LeVraiArdox
left a comment
There was a problem hiding this comment.
Uhm... It's good that it works, but don't take the "if it works don't touch it" too literally. The current structure is really not optimized, professional, logical (and it looks like an AI written code).
To implement this, you'd have to remake the whole thing. You should look at the sleex code to see how you should use Quickshell.
| exec-once = hyprctl setcursor Bibata-Modern-Classic 24 | ||
|
|
||
| # Onscreen Keyboard | ||
| exec-once = /usr/share/sleex/modules/virtualKeyboard/VirtualKeyboard.sh No newline at end of file |
There was a problem hiding this comment.
If it's a QS module, I don't understand why a script is necessary
There was a problem hiding this comment.
I apologize for my ignorance and naivete.
The shell script detects multiple monitors and executes "quickshell -q [QML FILE]" but I infer from your comment that it is not the proper way of doing things.
Thank you for making me aware, I will certainly work on it to make the necessary changes.
There was a problem hiding this comment.
Don't use image icons. There is a MaterialSymbols QML property.
MaterialSymbol {
text: "your_icon_name"
iconSize: Appearance.font.pixelSize.normal
}You can find the available icons here
There was a problem hiding this comment.
Being new to QML I haven't had a clue. Thank you dearly for helping me.
Again, I profusely apologize for the lack of better code and conduct.
There was a problem hiding this comment.
https://github.com/4ka-s/Virtual-Keyboard
Inside the build files you'll find the C code for the binaries.
Close and Open are the binaries that create and kill the quickshell process.
I do realize that it is an absurd way of doing things, I was unaware if it was unacceptable.
Thank you dearly for your great critique, I assure you I will work on more concrete code conduct.
There was a problem hiding this comment.
Same thing as the other icon
| import Quickshell.Io | ||
| import QtQuick | ||
|
|
||
| ShellRoot { |
There was a problem hiding this comment.
You're creating a new shell instead of a shell element. Take inspiration on the dashboard to see how to make panels.
There was a problem hiding this comment.
Thank you for providing your valued guidance. I truly appreciate these remarks of yours.
| import Quickshell.Io | ||
| import QtQuick | ||
|
|
||
| ShellRoot { |
There was a problem hiding this comment.
ANOTHER shell for the osk ??
There was a problem hiding this comment.
Yes, one for the notification and another separate for the onscreen keyboard. I infer from your comment that this too is an absurd way of doing things; I'll take necessary measures.
Thank you for for pointing out all the flaws. I truly find your guidance valuable as a new learner.
|
|
||
| Text { | ||
| anchors.centerIn: parent | ||
| text: "📌" |
There was a problem hiding this comment.
MaterialSymbol would be more appreciated
There was a problem hiding this comment.
Being aware of it now, I'll make the necessary changes! Thank you again, Ardox.
| Rectangle { | ||
| width: 2/keyboardContainer.xScaleObject | ||
| height: (keyboardContainer.height * 0.8)/keyboardContainer.yScaleObject | ||
| color: "#8F8F8F" |
There was a problem hiding this comment.
You shouldn't hardcode colors, there is a special method to use colors on the Sleex shell... Which is not appliable here because it's not the same shell
There was a problem hiding this comment.
I wasn't aware this was possible at all. Now that I am aware, I assure you I will figure out my way to that.
Thank you again, for bringing this to my attention. Your patience is truly appreciated.
| } | ||
|
|
||
| Repeater { | ||
| model: ["1", "2", "3", "4", "5", "6", "7", "8", "9", "0", "-", "="] |
There was a problem hiding this comment.
Hardcoding the keys ?
- Doesn't supports mutliple layouts
- A model can accept a number (12)
There was a problem hiding this comment.
Being quite new to this, I could not fancy a way to not hard code the keys. I am now aware that method is unacceptable. I will surely do better. My apologies Ardox.
| isSpecial: true | ||
| } | ||
|
|
||
| Repeater { |
There was a problem hiding this comment.
Making multiple repeaters ? One for each lines ?
possibly not a sub project and fixed dual monitor notification spawning