Feature/night mode exceptions

[euletheia]

Description

Add night mode exceptions (fullscreen and custom app list).

Drawing heavily on hthienloc/DankMaterialShell@de3e8cf, give the possibility to specify a list of applications excluded from Night Mode, alongside the ability to exclude fullscreen applications.

Logic is implemented on newly focused windows, and integrates with compositors overview mode so that Night Mode is resumed on overview.¹

Notes

• Abstracted the appId match function from MprisController:qml:20 to Paths.qml:154 with other (loosely-)related functions.

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that changes existing behavior)
• Refactor / internal cleanup
• Documentation
• Other

Related issues

Screenshots / video²

contrib_night-mode-exceptions.webm

Checklist

• My code follows the conventions in CONTRIBUTING.md
• I have tested my changes locally
• New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
• Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
• QML changes: ran make lint-qml with no new warnings
• I have opened a corresponding pull request in dlx-docs to document any new behaviors: https://github.com/AvengeMedia/DankLinux-Docs

Footnotes

1. This means that enabling fullscreen exclusion while fullscreen will do nothing because the implementation reacts to Toplevel change (application focus). ↩

2. Screen gamma change is obviously not visible in the video, but "it works on my machine". ↩

[dionjoshualobo]

I noticed that when the Fullscreen Applications is turned on, and if any one app in the workspace is fullscreen, it turns of night mode for all the apps in the workspace. Is it intentional?

[euletheia]

That's a regression caused by the unnecessary additional commit I carelessly pushed earlier.
I just dropped it and NightMode should resume if you switch from a fullscreen app to any non-fullscreen window, as was originally planned.

Thank you !

[dionjoshualobo]

The "excluding apps from night mode" makes sense, but the one with "full screen disabling night mode" doesn't make sense to me. Anyway, up to the maintainers to approve

[euletheia]

To me, the point of allowing users to disable night mode for fullscreen apps is to ensure color accuracy for applications typically run in fullscreen mode, like media players and video games.

[euletheia]

Two shortcomings I've noticed¹ and I'm not sure how to solve:

• Making a window fullscreen with nightModeExcludeFullscreen enabled seems to cause some minor "flickering".
• Switching from a fullscreen window (with nightModeExcludeFullscreen enabled) to the Niri overview mode introduces a slight but noticeable delay before the blurred wallpaper shows.

---

EDIT:

• seems like 2bafc21 solved most of the problem.
• I'd still like to "fix" the abrupt temperature change: following is a basic QML patch to animate state switching.
  • I'm not sure about how to properly do error handling here,
  • It spawns a lot of IPC requests (very noisy in debug mode).

If time permits, I'd be glad to try my hand at a Go implementation, but I'm unsure how an animation player that handles bezier curves would fit in the wayland pkg. Would it make sense for it to live in a separate file, and be hooked into the manager.go:schedulerLoop() ? If you have any time to spare to provide some hints or directions, it would be greatly appreciated.

night-mode-transition-basic.patch

Footnotes

1. at least on Niri, and at least on my laptop. ↩

[bbedward]

/claude review

[claude]

Claude review

Feature logic is sound, but pausing writes through to session.json and two log references are out of scope.

• Pause persists nightModeEnabled: false to session.json via disableNightMode() → night mode is lost across a restart while paused, plus a disk write per focus switch — quickshell/Services/DisplayService.qml:1078
• log is undefined in popupLoader.recreatePopup(); the Log.scoped() property is declared on the SettingsCard at line 688 instead of the root Item — quickshell/Modules/Settings/GammaControlTab.qml:51
• log is undefined in popupLoader.recreatePopup(); no log property exists in this file — quickshell/Modules/Settings/MediaPlayerTab.qml:38
• Leftover unused import qs.Modules.WorkspaceOverlays (Services → UI dependency) — quickshell/Services/DisplayService.qml:10

Checked: night mode pause/resume state machine and its interaction with SessionData persistence, the new ToplevelManager/CompositorService connections, CompositorService.inOverview wiring across Hyprland/Niri/Mango, the Paths.isAppIdMatch extraction against the original MprisController logic, the SettingsData list helpers, and the popup Loader refactor in the three settings tabs; I18n wrapping and untouched en.json/template.json are fine. Model: claude-opus-5.

[euletheia]

@bbedward
All functions in DisplayService.qml now call the same setter _setGammaEnabled(), independently of the state they set.
The original behavior is preserved and everything works as expected on my end.