Fix mobile install intent tracking#1052
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the mobile download intent prompt tracking in the docs site so key App Store install analytics aren’t lost when the prompt intercepts App Store clicks, and so funnel events carry consistent metadata.
Changes:
- Adds a
getMobilePromptPropshelper to standardize Plausible event props for the mobile intent prompt funnel. - Preserves the primary
App Store InstallKPI by manually tracking it when the prompt intercepts an App Store click. - Loosens the ConvertKit submit guard to detect the mobile download form submission even when it dispatches outside the injected container.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| appStoreLink?.addEventListener("click", () => { | ||
| track("Mobile Download App Store Link Clicked"); | ||
| track("Mobile Download App Store Link Clicked", getMobilePromptProps()); |
Comment on lines
+455
to
+458
| const isMobileDownloadForm = | ||
| formContainer?.contains(form) || | ||
| (!container.hidden && form.dataset.svForm === "9491475"); | ||
| if (!isMobileDownloadForm) return; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
App Store Installtracking when the mobile intent prompt intercepts an App Store click before Plausible's class-based handler can observe it.Test plan