Skip to content

Fix/tooltip typo and status chip test - #928

Open
aramani-availity wants to merge 2 commits into
mainfrom
fix/tooltip-typo-and-status-chip-test
Open

Fix/tooltip typo and status chip test#928
aramani-availity wants to merge 2 commits into
mainfrom
fix/tooltip-typo-and-status-chip-test

Conversation

@aramani-availity

Copy link
Copy Markdown
Contributor

Added minor fixes for

  1. mui-tooltip : typo in leaveDelay description (micro seconds → milliseconds)
  2. mui-chip: replace StatusChip test importing wrong component. (Chip -> StatusChip)

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Preview deployed!

📖 View Storybook Preview

import { StatusChip } from './StatusChip';

describe('Chip', () => {
describe('StatusChip', () => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to make changes, but as a general note for the future - since these changes are for only tests and docs then a new version is not needed.

if you were instead to name the commits test(mui-chip): fix StatusChip test importing wrong component and docs(mui-tooltip): fix typo in leaveDelay description (micro seconds → milliseconds) then semver would skip those commits when determining version.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, quick correction. we skip docs commits, but not test. so test would still trigger a new version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants