-
Notifications
You must be signed in to change notification settings - Fork 86
Add configurable distribution modes for federation delivery #3044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pfefferle
wants to merge
13
commits into
trunk
Choose a base branch
from
add/distribution-mode-setting
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d5821d8
Add configurable distribution modes for federation delivery
pfefferle 06333bf
Add changelog
matticbot 8f4128e
Merge branch 'trunk' into add/distribution-mode-setting
pfefferle 5bb502d
Address review feedback for distribution mode settings
pfefferle 03c4f0b
Document no-inline-namespaces convention in AGENTS.md
pfefferle 6a2a01d
Merge branch 'trunk' into add/distribution-mode-setting
pfefferle ab9ed9c
Address review feedback for distribution modes
pfefferle 82eb6e5
Add upper bounds for custom distribution values and reject custom con…
pfefferle 7a84430
Adjust distribution mode pause values to 15s, 30s, 30s
pfefferle e88da82
Merge branch 'trunk' into add/distribution-mode-setting
pfefferle 44b5f22
Address code review feedback for distribution mode
pfefferle bc54e44
Address remaining review suggestions for distribution mode
pfefferle 03497e5
Align custom distribution defaults with the default preset
pfefferle File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: patch | ||
| Type: added | ||
|
|
||
| Add a Distribution Mode setting to control how quickly posts are delivered to followers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| /** | ||
| * Toggle the custom distribution-mode fields based on the selected radio. | ||
| * | ||
| * The custom batch-size / pause inputs are only relevant when the | ||
| * "custom" preset is active. They stay hidden for all other presets. | ||
| */ | ||
|
|
||
| ( function() { | ||
| const radios = document.querySelectorAll( 'input[name="activitypub_distribution_mode"]' ); | ||
| const fields = document.getElementById( 'activitypub-custom-distribution-fields' ); | ||
|
|
||
| if ( ! fields || ! radios.length ) { | ||
| return; | ||
| } | ||
|
|
||
| function updateVisibility( value ) { | ||
| fields.style.display = 'custom' === value ? '' : 'none'; | ||
| } | ||
|
|
||
| radios.forEach( function( radio ) { | ||
| radio.addEventListener( 'change', function() { | ||
| updateVisibility( this.value ); | ||
| } ); | ||
| } ); | ||
| }() ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.