Remove unused icon component and Rive AI-icon hook#4313
Open
wojtekn wants to merge 2 commits into
Open
Conversation
Deletes the dead useAiIcon hook, its .riv asset and test mock, the @rive-app/react-canvas dependency, and the associated Rive/WASM bundling in the Electron Vite config. The wasm() plugin and **/*.wasm handling are kept for PHP-WASM/Playground.
Collaborator
📊 Performance Test ResultsComparing 9cfb1cb vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Follow-up to #4293. Used Claude Code with Knip to identify unused UI code, then manually verified each finding had no references (including dynamic/string references and test mocks) before removing it. The Rive removal footprint (asset, test mock, dependency, and Vite bundling) was traced by hand.
Proposed Changes
Removes two pieces of dead UI code and their supporting infrastructure. No user-visible impact — neither was rendered anywhere. This trims an unused animation dependency and its WASM bundling, slightly reducing install and build surface.
@rive-app/react-canvasdependency, and the Rive-specific WASM copying in the Electron Vite config.Testing Instructions
npm run typecheckpasses across all workspaces.npm test -- apps/studiopasses (684 tests) — confirms removing theuse-ai-icontest mock had no fallout.npx knipno longer reports the two icons, and@rive-app/*is fully gone from the dependency graph.Pre-merge Checklist