Fix MAIN_MIN_WIDTH regression from DEFAULT_WIDTH bump#3612
Open
wojtekn wants to merge 1 commit into
Open
Conversation
MAIN_MIN_WIDTH was derived from DEFAULT_WIDTH, so when DEFAULT_WIDTH was increased from 900 to 1100 (in #3161), the minimum window width silently jumped from 712 to 912. Hardcode 712 to restore the original value.
Collaborator
📊 Performance Test ResultsComparing 0872ce2 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude Code identified the root cause and applied the fix.
Proposed Changes
MAIN_MIN_WIDTHto712(the original value:900 - 208 + 20) instead of deriving it fromDEFAULT_WIDTHWhen
DEFAULT_WIDTHwas bumped from900to1100in #3161,MAIN_MIN_WIDTHsilently grew from712to912, making the app window unexpectedly constrained to a much wider minimum. Decoupling the two constants restores the previous behaviour.Testing Instructions
Pre-merge Checklist