Closed
Conversation
e3f74e2 to
69d0f06
Compare
Collaborator
📊 Performance Test ResultsComparing 69d0f06 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Contributor
|
I'm hesintant about this PR. How does this relate to the sessions work in #2767 Is it just one part of it? |
Contributor
Author
I wasn't aware of that PR. I was using a variation of this when working on #2772 to help debug calls within the CLI rendering (agents could use it as a fast feedback loop). However given the PR you shared I don't think this is necessary because agents could read the session data to get necessary feedback. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How AI was used in this PR
I used Codex to scaffold the utility module, then reviewed the API shape and verified the branch with lint, typecheck, a CLI build, and targeted CLI tests.
Proposed Changes
apps/cli/lib/debug-log.tsprovider-constants-slice.tsRedundancy Check
Loggerinapps/cli/logger.ts; it is a user-facing progress/error channel for spinners, IPC status, and loader text, not a persisted debug trace sinkstudio aicommand path; progress is wired into the TUI loader, so using the existing logger for raw debug payloads would mix internal tracing into the chat UIapps/studio/src/logging.ts; that is Electron-side rotating console/file logging and is not a reusable standalone CLI debug facilitydebug.logsupport; that captures PHP/WordPress runtime issues, not CLI or agent-tool execution tracesPotential Follow-ups
apps/cli/logger.tsinstead of keeping a separate helperTesting Instructions
npx eslint --fix apps/cli/lib/debug-log.ts apps/cli/lib/tests/debug-log.test.ts apps/studio/src/stores/provider-constants-slice.tsnpm test -- apps/cli/lib/testsnpm run typechecknpm run cli:buildconst debugLog = createDebugLogger( { enabledEnvVar: "STUDIO_AI_DEBUG", defaultFilename: "studio-ai-debug.log", scope: "todo-rendering" } );debugLog.log( "todo_tool_use_received", { input } );STUDIO_AI_DEBUG=1STUDIO_AI_DEBUG_FILE=/tmp/studio-ai-debug.logPre-merge Checklist