feat(chrome-ext): enable use of the CSS Custom Highlights API for Firefox#2425
Closed
elijah-potter wants to merge 2 commits intoAutomattic:masterfrom
Closed
feat(chrome-ext): enable use of the CSS Custom Highlights API for Firefox#2425elijah-potter wants to merge 2 commits intoAutomattic:masterfrom
elijah-potter wants to merge 2 commits intoAutomattic:masterfrom
Conversation
elijah-potter
force-pushed
the
enable-firefox
branch
from
01bd124 to
ad775ea
Compare
elijah-potter
force-pushed
the
enable-firefox
branch
from
ad775ea to
013c7be
Compare
Collaborator
Author
|
It looks like we need to wait until the next version of Playwright releases (which will support the updated version of Firefox). |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #2414
Description
In version 146, Firefox finally merged full support for the
text-decorationfield in the CSS Custom Highlights API. This was the last thing needed to switch Harper from the DOM-based highlight renderer on Firefox to the new one. This should hopefully resolve many of the 'highlight drift' issues Firefox users have been experiencing.Note that this PR bumps the minimum required Firefox version to
146.How Has this Been Tested?
Manually.
Checklist