Enforce arguments constraint reflexively#102
Open
jugglinmike wants to merge 1 commit intoAutomattic:masterfrom
Open
Enforce arguments constraint reflexively#102jugglinmike wants to merge 1 commit intoAutomattic:masterfrom
arguments constraint reflexively#102jugglinmike wants to merge 1 commit intoAutomattic:masterfrom
Conversation
fb55
added a commit
to cheeriojs/cheerio
that referenced
this pull request
Feb 25, 2014
As long as Automattic/expect.js#102 isn't resolved, 0.3 causes bugs.
If an `arguments` object is not considered `eql` to an array, then the inverse should also hold true.
Author
|
I've updated the code style to match the the patch that was recently merged into Node core. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My personal preference would be for
eqlto be more lax (as opposed to less)--consideringargumentsobjects as equivalent to arrays if their elements are deeply equal. Since this project uses Node.js'sdeepEquallogic, I assume this is not the intention ofeql. The important thing is consistency, as a patch like 7c20523 should not have effected downstream libraries.Commit message: