Skip to content

Harden php-transformer canonical contracts#38

Merged
chubes4 merged 1 commit into
trunkfrom
cook/php-transformer-contract-audit-cleanup
Jun 21, 2026
Merged

Harden php-transformer canonical contracts#38
chubes4 merged 1 commit into
trunkfrom
cook/php-transformer-contract-audit-cleanup

Conversation

@chubes4

@chubes4 chubes4 commented Jun 21, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Tighten canonical result validation for required top-level keys, status values, report placement, conversion report schema/source format, and materialization plan schema/shape.
  • Make MaterializationPlanBuilder::fromResult() validate canonical envelopes and return the canonical embedded plan instead of silently rebuilding or accepting partial arrays.
  • Remove product-shaped products output from the canonical materialization plan while keeping source manifests available as generic artifacts/assets.
  • Update contract coverage and the result envelope docs so legacy_mapping is rejected rather than documented as required/transitional.

Verification

  • composer validate
  • composer test
  • git diff --check

AI assistance

  • AI assistance: Yes
  • Tool(s): openai/gpt-5.5 via OpenCode
  • Used for: Auditing php-transformer canonical contracts, implementing validation/test/doc cleanup, and preparing the PR.

@chubes4 chubes4 merged commit 07bca9f into trunk Jun 21, 2026
1 check passed
@chubes4 chubes4 deleted the cook/php-transformer-contract-audit-cleanup branch June 21, 2026 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant