Skip to content

Remove all try-catch blocks from CalculaBaseCalculoIbsCbs #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertorp merged 3 commits into from
Nov 6, 2025
Merged

Remove all try-catch blocks from CalculaBaseCalculoIbsCbs #45

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a472af
Initial plan
Copilot Nov 6, 2025
a610338
fix: replace generic catch clause with explicit Exception type
Copilot Nov 6, 2025
bec1482
refactor: remove all try-catch blocks from CalculaBaseCalculoIbsCbs
Copilot Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 8 additions & 40 deletions src/MotorTributarioNet/Impostos/CalulosDeBC/CalculaBaseCalculoIbsCbs.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,50 +90,26 @@ public decimal CalculaBaseCalculo()
/// </summary>
private decimal CalcularValorPis()
{
try
{
var tributacaoPis = new TributacaoPis(_tributavel, _tipoDesconto);
return tributacaoPis.Calcula().Valor;
}
catch
{
// Em caso de erro no cálculo, retorna 0 para não impactar o cálculo do IBS/CBS
return 0m;
}
var tributacaoPis = new TributacaoPis(_tributavel, _tipoDesconto);
return tributacaoPis.Calcula().Valor;
}

/// <summary>
/// Calcula o valor da COFINS para dedução da base
/// </summary>
private decimal CalcularValorCofins()
{
try
{
var tributacaoCofins = new TributacaoCofins(_tributavel, _tipoDesconto);
return tributacaoCofins.Calcula().Valor;
}
catch
{
// Em caso de erro no cálculo, retorna 0 para não impactar o cálculo do IBS/CBS
return 0m;
}
var tributacaoCofins = new TributacaoCofins(_tributavel, _tipoDesconto);
return tributacaoCofins.Calcula().Valor;
}

/// <summary>
/// Calcula o valor do ICMS para dedução da base
/// </summary>
private decimal CalcularValorIcms()
{
try
{
var tributacaoIcms = new TributacaoIcms(_tributavel, _tipoDesconto);
return tributacaoIcms.Calcula().Valor;
}
catch
{
// Em caso de erro no cálculo, retorna 0 para não impactar o cálculo do IBS/CBS
return 0m;
}
var tributacaoIcms = new TributacaoIcms(_tributavel, _tipoDesconto);
return tributacaoIcms.Calcula().Valor;
}

/// <summary>
Expand All @@ -143,16 +119,8 @@ private decimal CalcularValorIssqn()
{
if (_tributavel.IsServico && _tributavel.PercentualIssqn > 0)
{
try
{
var tributacaoIssqn = new TributacaoIssqn(_tributavel, _tipoDesconto);
return tributacaoIssqn.Calcula(false).Valor;
}
catch
{
// Em caso de erro no cálculo, retorna 0 para não impactar o cálculo do IBS/CBS
return 0m;
}
var tributacaoIssqn = new TributacaoIssqn(_tributavel, _tipoDesconto);
return tributacaoIssqn.Calcula(false).Valor;
}
return 0m;
}
Expand Down