Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eaf48941f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - 'v[0-9]+.[0-9]+.[0-9]+' # stable: v1.2.3 | ||
| - 'v[0-9]+.[0-9]+.[0-9]+-*' # pre-rel: v1.2.3-beta.1 |
There was a problem hiding this comment.
The on.push.tags filters are written in regex style ([0-9]+) but GitHub Actions tag filters use glob matching, where + is treated as a literal character. As written, tags like v1.2.3 or v1.2.3-beta.1 (the release flow documented in .github/workflows/README.md) will not match these patterns, so the build/release workflow will not start on normal release tags.
Useful? React with 👍 / 👎.
| atom.commands.dispatch( | ||
| atom.views.getView(atom.workspace), | ||
| 'pulsar-updater:check-for-update' | ||
| 'crab-updater:check-for-update' |
There was a problem hiding this comment.
This command was renamed to crab-updater:check-for-update, but the repository still ships pulsar-updater and registers pulsar-updater:check-for-update (packages/pulsar-updater/src/main.js). In current builds, clicking “Check for Update” from About will dispatch a command that no package handles, so users cannot trigger update checks from this UI.
Useful? React with 👍 / 👎.
Resolved conflict: verified_build.sh deleted in current branch (kept deletion). All new packages and files from main accepted as-is. Made-with: Cursor
1 participant
Description
Please include a summary of the change and which issue is fixed.
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist: