Accessible tabs (tablists, tabs, tabpanels) #314
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -42,7 +42,8 @@ export default css` | |
| color:var(--primary-color); | ||
| } | ||
|
|
||
| .tab-btn:focus-visible, | ||
| .tab-btn.active:focus-visible { | ||
|
Comment on lines
+45
to
+46
|
||
| color:var(--secondary-color); | ||
| } | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| import { html } from 'lit'; | ||
| import { getI18nText } from '../languages/index.js'; | ||
| import { handleTabs } from '../utils/common-utils.js'; | ||
|
|
||
| /* eslint-disable indent */ | ||
| export default function codeSamplesTemplate(xCodeSamples) { | ||
|
|
@@ -17,16 +18,16 @@ export default function codeSamplesTemplate(xCodeSamples) { | |
| tabContents.forEach((tabBodyEl) => { tabBodyEl.style.display = (tabBodyEl.dataset.tab === clickedTab ? 'block' : 'none'); }); | ||
| } | ||
| }"> | ||
| <div class="tab-buttons row" role="tablist" style="width:100; overflow" @keydown="${handleTabs}"> | ||
| ${xCodeSamples.map((v, i) => html`<button class="tab-btn ${i === 0 ? 'active' : ''}" role="tab" id="codesample${i}-button" aria-controls="codesample${i}" aria-selected='${i === 0}' tabindex="${i === 0 ? 0 : '-1'}'" data-tab = '${v.lang}${i}'> ${v.label || v.lang} </button>`)} | ||
| </div> | ||
| ${xCodeSamples.map((v, i) => { | ||
| // We skip the first line because it could be there is no padding there, but padding on the next lines which needs to be removed | ||
| const paddingToRemove = Math.min(...v.source.split('\n').slice(1).map(l => l.match(/^(\s*).*$/m)?.[1].length).filter(l => typeof l !== 'undefined')); | ||
| const sanitizedSource = v.source.split('\n').map(s => s.substring(0, paddingToRemove).match(/^\s+$/) ? s.substring(paddingToRemove) : s); | ||
| const fullSource = sanitizedSource.join('\n'); | ||
| return html` | ||
| <div class="tab-content m-markdown code-sample-wrapper" id="codesample${i}" role="tabpanel" aria-labelledby="codesample${i}-button" tabindex="0" style= "display:${i === 0 ? 'block' : 'none'}" data-tab = '${v.lang}${i}'> | ||
| <syntax-highlighter language="${v.lang}" .content="${fullSource}" .label="${getI18nText('parameters.samples')}"/> | ||
| </div>`; | ||
| }) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -188,3 +188,29 @@ export function getSanitizedEmail(emailRaw) { | |||||
|
|
||||||
| return ''; | ||||||
| } | ||||||
|
|
||||||
| export function handleTabs(e) { | ||||||
|
Member
There was a problem hiding this comment.
Suggested change
Also I'm not seeing why this shouldn't be a full component which tabs a list of child components as slots. Would slots work here, I forget, can you have the same slot filled multiple times and have it render correctly? I think so. Maybe a question is, are you familiar with html component slots? |
||||||
| const b = e.target; | ||||||
| if (b.tagName.toLowerCase() !== 'button') { return; } | ||||||
| const buttons = Array.from(b.parentElement.children); | ||||||
| const i = buttons.indexOf(b); | ||||||
| let newIndex = 0; | ||||||
| switch (e.key) { | ||||||
| case 'ArrowRight': | ||||||
| newIndex = (i + 1) % buttons.length; | ||||||
| break; | ||||||
| case 'ArrowLeft': | ||||||
| newIndex = (i - 1 + buttons.length) % buttons.length; | ||||||
| break; | ||||||
| case 'Home': | ||||||
| newIndex = 0; | ||||||
| break; | ||||||
| case 'End': | ||||||
| newIndex = buttons.length - 1; | ||||||
| break; | ||||||
| default: | ||||||
| return; | ||||||
| } | ||||||
| b.parentElement.children[newIndex].focus(); | ||||||
| } | ||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does renderStyle matter, and why aren't we using h4, h5 for this?