Keep players logged in across server switches when the pre-join dialog is enabled#3098
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
With a proxy +
autoLogin: true, an already-authenticated player switching back to an auth server gets re-prompted to log in on Paper/Folia backends that haveregistration.dialog.preJoin.enable: true.The pre-join dialog is shown during the connection configuration phase, which on a switch fires before the proxy sends
perform.login(sent only fromServerConnectedEvent, after configuration completes). The dialog blocks that phase, so the auto-login can't arrive in time and the dialog always wins. Same symptom as #3076 (itsperform.loginrouting part was already fixed in63dccbf).Fix
Send the auto-login during the configuration phase and let the backend act on it:
PlayerEnteredConfigurationEvent, send the HMAC-signedperform.loginto the auth server before the backend shows the dialog (ServerConnectedEventpath kept as backstop).PaperProxyAutoLoginListenerhandles the configuration-phasePluginMessageListeneroverload; on a validperform.loginit queues the proxy session and dismisses the dialog (approvePreJoinForceLogin).BungeeReceiver.handleConfigPhasePerformLoginreuses the existingverifyHmac, andPaperDialogFlowListenerre-checks the queue after registering the dialog future to close the residual race.Not yet verified on a live Paper + Velocity network.
Refs #3076