Open
Conversation
|
Weirdness happens when the arguments are constants. Probably not caused by this PR though: fn fail() {
assert_eq!(1, 2);
} |
ThomasMayerl
force-pushed
the
fix_assert_eq
branch
from
82d65cc to
4430d81
Compare
Aurel300
reviewed
Feb 18, 2026
Aurel300
reviewed
Feb 18, 2026
Sorry, I didn't look at the comments properly. The `builtin_deref` unwrap should never fail
Collaborator
|
@ThomasMayerl one last thing: 110 tests fail here, while only 107 fail on the main branch. Could you check the diff of failing tests and double check that there isn't a regression |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #134 by requiring false as a precondition for assert_failed (similar to panic)