Fix mobile dark mode not activating when theme is set to auto#14038
Open
dylanjeffers wants to merge 2 commits intomainfrom
Open
Fix mobile dark mode not activating when theme is set to auto#14038dylanjeffers wants to merge 2 commits intomainfrom
dylanjeffers wants to merge 2 commits intomainfrom
Conversation
The selector fallback derived system appearance from the stored theme value instead of querying the actual device appearance. When theme was AUTO, `theme === Theme.DARK` evaluated to false, always defaulting to light. Additionally, replaced react-native-dynamic's useDarkMode with React Native's built-in useColorScheme for more reliable appearance detection. https://claude.ai/code/session_01UTyTyh99xC4WeohtPJWtVF
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The selector fallback derived system appearance from the stored theme value
instead of querying the actual device appearance. When theme was AUTO,
theme === Theme.DARKevaluated to false, always defaulting to light.Additionally, replaced react-native-dynamic's useDarkMode with React
Native's built-in useColorScheme for more reliable appearance detection.
https://claude.ai/code/session_01UTyTyh99xC4WeohtPJWtVF