Skip to content

feat: storage provider abstraction + FTP provider#168

Merged
phmatray merged 26 commits into
devfrom
storage-providers
Jun 2, 2026
Merged

feat: storage provider abstraction + FTP provider#168
phmatray merged 26 commits into
devfrom
storage-providers

Conversation

@phmatray
Copy link
Copy Markdown
Contributor

@phmatray phmatray commented Jun 2, 2026

Summary

Introduces a storage-provider abstraction so the VFS can load from / write to multiple backends, migrates the existing GitHub support onto it with no behavior change, and adds a read+write FTP provider with a capability-driven Blazor UI. Built per the design spec & plan under docs/superpowers/ (merged via #167).

  • Atypical.VirtualFileSystem.Providers.Abstractions (new): IStorageProvider, IStorageProviderAuth, ProviderCapabilities, and neutral records. Branch/PR/fork are capability flags + CommitContext fields (not base-interface methods), so providers that can't do PRs (FTP) simply ignore them.
  • GitHub migration: GitHubStorageProvider/GitHubProviderAuth/adapters wrap the existing Octokit loader & write service — the original 71 GitHub tests still pass (regression gate).
  • Atypical.VirtualFileSystem.Ftp (new): FtpStorageProvider over FluentFTP behind an IFtpConnection seam (TDD against an in-memory fake) — recursive import with size filtering, read, and write (per-file overwrite/delete with partial-success results), leak-safe connect/disconnect, TLS opt-in.
  • Blazor: IStorageProviderRegistry selects the active provider; a capability-driven import dialog (provider picker) and capability-gated "submit changes" (PR for GitHub, upload for FTP). GitHub import/PR flows preserved unchanged; FTP credentials persisted encrypted via ProtectedLocalStorage.

Each phase was implemented test-first and passed spec + code-quality review.

Follow-ups (out of scope, tracked)

  • FTP write-back change-tracking (the upload path is plumbed + tested; the change-set tracker is deferred).
  • Route GitHub through the neutral provider to retire the legacy GitHub-named services.
  • Apply extension/glob filters in FTP import; rename GitHubImportDialog → StorageImportDialog.
  • OneDrive (Microsoft Graph + OAuth) — see issue [REVENUE] Implement cloud backend adapters (S3, Azure Blob, GCS) #132.

Test plan

  • dotnet build Atypical.VirtualFileSystem.sln -c Release — 0 errors
  • dotnet test — 970 test runs pass on net9.0 + net10.0 (399 Core + 76 GitHub + 5 Abstractions + 5 FTP, ×2 TFMs)
  • DemoBlazorApp starts cleanly; GitHub flow unchanged, FTP provider selectable & imports

🤖 Generated with Claude Code

Philippe Matray and others added 26 commits June 2, 2026 11:54
@claude
feat(providers): scaffold Providers.Abstractions project
e86104d 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(providers): add AuthKind, ProviderCapabilities, ProviderAccountInfo
72eb341 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(providers): add neutral load/read/write records
e8bf2b0 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(providers): add IStorageProvider and IStorageProviderAuth
3982223 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
test(providers): abstractions test project + capability tests
9868aba 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
refactor(providers): add abstraction XML docs and broaden contract tests
7ccca01 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
build(github): reference Providers.Abstractions
070d1f3 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(github): add GitHub<->neutral provider adapters
5cc0632 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(github): add GitHubProviderAuth (Token)
7857320 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(github): add GitHubStorageProvider wrapping the loader
7ff2378 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
fix(github): map ProviderLoadOptions.RemoteRoot to SubPath (remote fi…
0d9d322 
…lter), not TargetPath

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
refactor(github): forward glob filter intent and fix result RemoteRoot
b28400a 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(ftp): scaffold Ftp project with FluentFTP
51bcc53 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(ftp): IFtpConnection seam + FluentFTP implementation
fa427d6 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(ftp): FtpStorageProvider import + FtpProviderAuth (TDD with fake)
94932ec 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(ftp): WriteChangesAsync overwrite/delete with per-file results
210ee6a 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(ftp): AddVirtualFileSystemFtp DI registration
a5fb723 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
refactor(ftp): consistent auth guard, leak-safe disconnect, dir nodes…
6bcbbc5 
…, TLS hardening

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(blazor): storage provider registry
0736337 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(blazor): register GitHub and FTP providers + registry
47e9fd4 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(blazor): neutral StorageImportService + encrypted credential store
1a56b62 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
refactor(blazor): guard concurrent imports and align registry event n…
eb46f26 
…aming

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(blazor): capability-driven import dialog with provider picker
c8c4056 
Add a provider <select> at the top of the import dialog driven by
IStorageProviderRegistry, and render the field set from the active
provider's capabilities. GitHub (SupportsBranches) keeps the existing
owner/repo/branch/subpath fields and GitHubImportService flow unchanged;
credentials providers (FTP) get host/port/username/password/useTls/base-path
fields, authenticate via Registry.Active.Auth, persist via
StorageCredentialStore, and import via StorageImportService.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
feat(blazor): capability-driven submit-changes (PR vs upload)
04af402 
Add StoragePendingChangesService exposing SupportsPullRequests (from the
active provider's capabilities) and SubmitAsync, which routes ProviderFileChange
sets to the active provider's WriteChangesAsync. Gate CreatePullRequestDialog by
capability: GitHub (SupportsPullRequests) keeps the existing fork->branch->commit->PR
flow and "Create Pull Request" button untouched; non-PR providers (FTP) show an
"Upload changes" confirmation view and button that calls SubmitAsync.

Note: FTP change-set tracking from VFS edits is not yet wired (no tracker
populates changes for FTP-imported files), so the upload list is empty today;
the capability gating, labelling, and service plumbing are in place for when
that tracking lands.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
refactor(blazor): guard non-PR submit and align dispatcher marshalling
3f604cc 
Throw InvalidOperationException from StoragePendingChangesService.SubmitAsync
when the active provider supports pull requests, turning a future mis-call into
a clear contract violation instead of WriteChangesAsync's NotSupportedException.

Marshal the bare StateHasChanged() calls in OnProviderChanged and StartFtpImport
through InvokeAsync for consistency with the other awaited Dispatcher calls.

Document that FTP credential fields are intentionally not cleared on Close so
they re-prefill from the credential store next time, unlike the GitHub fields.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@claude
docs: document storage provider abstraction and FTP provider
fa06f57 
Add a Storage Providers section to CLAUDE.md (IStorageProvider abstraction,
capability-driven branch/PR handling, GitHub + FTP implementations, the Blazor
registry/UI), and correct the plan's misleading subpath-mapping comment to
reflect the implemented SubPath (remote filter) vs TargetPath (VFS destination).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@phmatray phmatray merged commit 11a1351 into dev Jun 2, 2026
1 check passed
@phmatray phmatray deleted the storage-providers branch June 2, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@phmatray