netatop: use const ptr struct for micro-op and readability - #393
Open
GermanAizek wants to merge 1 commit into
Open
netatop: use const ptr struct for micro-op and readability#393GermanAizek wants to merge 1 commit into
GermanAizek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor change use const pointer for code readability and better codegeneration by compiler (stack params function).
@Atoptool,
If you are interested in how assembly code on -O3 is micro-optimized in gcc, I can throw off asm listing images before and after calling fill_networkcnt() function. Example in netatop_bpf_exitfind()