Remove dead code in val2memstr: MAXEBYTE8 equals LLONG_MAX - #391
Open
natoscott wants to merge 1 commit into
Open
Remove dead code in val2memstr: MAXEBYTE8 equals LLONG_MAX#391natoscott wants to merge 1 commit into
natoscott wants to merge 1 commit into
Conversation
MAXEBYTE8 is defined as (ONEEBYTE*7 + (ONEEBYTE-1)) which evaluates to 9223372036854775807 — exactly LLONG_MAX. Since count_t is signed long long, the check "verifyval <= MAXEBYTE8" is always true, making the OVFORMAT branch unreachable dead code. Simplify: anything past MAXPBYTE is unconditionally EBFORMAT. Remove the unused MAXEBYTE8, MAXEBYTE, EBFORMAT_INT and OVFORMAT symbols. Found by Coverity Scan (CID 504429, CID 504430).
Contributor
|
@natoscott, |
Contributor
Author
|
@GermanAizek thank you for the kind words - it's nice to see you here too! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MAXEBYTE8 is defined as (ONEEBYTE*7 + (ONEEBYTE-1)) which evaluates to 9223372036854775807 — exactly LLONG_MAX. Since count_t is signed long long, the check "verifyval <= MAXEBYTE8" is always true, making the OVFORMAT branch unreachable dead code.
Simplify: anything past MAXPBYTE is unconditionally EBFORMAT. Remove the unused MAXEBYTE8, MAXEBYTE, EBFORMAT_INT and OVFORMAT symbols.
Found by Coverity Scan (CID 504429, CID 504430).