onclose callback not called when connection close by timeout#292
Open
SuperPat45 wants to merge 1 commit intoAtmosphere:masterfrom
Open
onclose callback not called when connection close by timeout#292SuperPat45 wants to merge 1 commit intoAtmosphere:masterfrom
SuperPat45 wants to merge 1 commit intoAtmosphere:masterfrom
Conversation
onclose callback not called when connexion close by timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onclose callback not called when connection closed by timeout
If the connection is closed by offline, the onclose callback was already called, but since the connection is in close state, the callback is not called twice, so It seems fined.