Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughAdds AtCoder Typical Contest entry Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/lib/utils/contest.ts`:
- Around line 317-327: The regexForAxc currently matches "atc" with only three
digits but lacks an end anchor and classifyContest still only special-cases
atc001; update regexForAxc to require end-of-string so it rejects "atc1234"
(i.e., make it match ^(abc|arc|agc|atc)\d{3}$) and update classifyContest to
explicitly treat any contest_id matching /^atc\d{3}$/i as ContestType.OTHERS
(the same classification used for atc001) so admin import logic (the code around
the current admin import check) and rendering remain consistent; alternatively
have the admin import flow call classifyContest instead of repeating checks so
both use the same rule.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6c031ac4-01f3-44f7-9fc3-d6878025ae15
📒 Files selected for processing (3)
src/lib/utils/contest.tssrc/test/lib/utils/test_cases/contest_name_labels.tssrc/test/lib/utils/test_cases/contest_type.ts
close #3239
Summary by CodeRabbit