backport: fix inappropriate connection reuse when using HTTP proxy if the initial CONNECT failed#2074
Closed
jasonjoo2010 wants to merge 1 commit intoAsyncHttpClient:2.12.4from
Conversation
jasonjoo2010
changed the title
There is an extra CONNECT request needs to send before the real request to the HTTP proxy and the 2nd request only happens if the CONNECT request succeeds. When CONNECT failed, the connection should be dropped as it's not in connected state. Signed-off-by: Jason Joo <hblzxsj@gmail.com>
jasonjoo2010
force-pushed
the
fix/back-port-http-proxy-connect-failure-2.12
branch
from
70073f5 to
2409335
Compare
Member
|
Unfortunately, v2 is EoL and it'll not receive any updates. But thanks a lot for fixing this in v3. :) |
Contributor
Author
|
got it, I will notify internal users about this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a backport fix(#2072) for #2071 on 2.12.x