implement the unix domain socket#1688
implement the unix domain socket#1688silence-code wants to merge 3 commits intoAsyncHttpClient:mainfrom
Conversation
slandelle
left a comment
slandelle
left a comment
There was a problem hiding this comment.
The problem with this PR is that is completely break the existing API because of the InetAddress to SocketAddress change.
Sadly, I'm not willing to break everything now for the sole sake of supporting domain sockets. Maybe in a future major release.
client/src/main/java/org/asynchttpclient/RequestBuilderBase.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/asynchttpclient/netty/channel/ChannelManager.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/asynchttpclient/netty/channel/EpollDomainTransportFactory.java
Outdated
Show resolved
Hide resolved
client/src/main/java/org/asynchttpclient/netty/channel/KQueueDomainTransportFactory.java
Outdated
Show resolved
Hide resolved
| abort(null, future, getCause(cause)); | ||
| } | ||
| }); | ||
| }else { |
There was a problem hiding this comment.
My idea does not meet the formatting rules, please help format
|
Thanks for your code review, I will take the time to solve the problem of breaking these existing APIs. |
|
I have reduced the breaking of the original API |
|
Can I ask which version can incorporate this function? |
slandelle
force-pushed
the
master
branch
5 times, most recently
from
6ea11f4 to
f8fab66
Compare
|
When will this feature be supported? |
|
Fixes #1670. |
|
@vy PR needs to be rebased with 3.x branch; are you willing to pick it up? Or I can do as well. |
|
@hyperxpro, I was just trying to get the GitHub references right. |
5 participants
usage can see example.CompletableFutures