feat: register Discord command groups - #9445
Draft
casama233 wants to merge 1 commit into
Draft
Conversation
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #9258.
Note
This is a Draft proposal for maintainer feedback. It does not migrate any plugin commands by itself and is not requesting immediate merge.
Discord currently skips
CommandGroupFilterand every childCommandFilterduring application command registration. Plugins that use AstrBot command groups therefore have no discoverable Discord slash command, while plugins that flatten their command tree can consume a large part of Discord's application command quota.The proposed mapping was discussed in #9258 before implementation:
#9258 (comment)
A separate Draft plugin migration demonstrates the intended consumer without coupling its review or merge to this core PR:
vmoranv-reborn/astrbot_plugin_pixiv_reborn#48
Modifications / 改动点
CommandGroupFilteras one PycordSlashCommandGroup.paramsstring on each leaf command. This avoids overlapping with the separate typed-option work in Discord 适配器增强功能 #9125.command -> subcommand group -> subcommand.Scope boundary:
Existing flattened plugin commands are not rewritten or removed.
Plugins opt in only by using AstrBot's existing
command_groupdecorators.This PR is independent of the Pixiv authentication PR and can be reviewed on its own.
No new dependency is introduced.
This is NOT a breaking change. / 这不是一个破坏性变更。
Screenshots or Test Results / 运行截图或测试结果
Verification steps:
Result:
GitHub Actions also pass across the repository test suite, build, format check,
CodeQL, and startup smoke tests on Ubuntu, macOS, and Windows with Python
3.10–3.14.
The generated payload was also checked with the real Pycord classes. A root group with one direct command and one nested group serializes as:
The two leaf callbacks rebuild
pixiv search <params>andpixiv user detail <params>respectively.Checklist / 检查清单
😊 If there are new features added in the PR, I have discussed it with the authors through issues/emails, etc.
/ 如果 PR 中有新加入的功能,已经通过 Issue / 邮件等方式和作者讨论过。
👀 My changes have been well-tested, and "Verification Steps" and "Screenshots" have been provided above.
/ 我的更改经过了良好的测试,并已在上方提供了“验证步骤”和“运行截图”。
🤓 I have ensured that no new dependencies are introduced, OR if new dependencies are introduced, they have been added to the appropriate locations in
requirements.txtandpyproject.toml./ 我确保没有引入新依赖库,或者引入新依赖库的同时将其添加到
requirements.txt和pyproject.toml文件相应位置。😮 My changes do not introduce malicious code.
/ 我的更改没有引入恶意代码。
Summary by Sourcery
Register Discord slash commands for AstrBot command groups so grouped commands appear as a single top-level slash command with subcommands and one level of subcommand groups.
New Features:
Enhancements:
Tests: