-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: resolve WebUI DBUG mismatch and mobile log wrapping #8023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SiriusAhu
wants to merge
1
commit into
AstrBotDevs:master
Choose a base branch
from
SiriusAhu:fix/8021-webui-log-rendering
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mobile fix for "near-vertical" log wrapping (reported in #7987) currently only applies to structured logs. Non-structured logs (those that do not match the level regex) will still use
white-space: pre-wrapfrom the.console-log-lineclass (defined at line 378), causing them to wrap aggressively on narrow screens.To ensure all logs behave consistently on mobile, you should apply
min-width: max-contentandwhite-space: preto the base.console-log-lineclass as well. For structured logs, we should maintainwhite-space: normalon the grid container to preserve the layout while allowing the message child to handle its own wrapping/scrolling.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I’ll test the non-structured log case on mobile first and update the PR if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I checked the current reproduction scope, and all observed platform logs are still going through the structured path. Since this PR is focused on the confirmed DBUG mismatch and the mobile layout issue reported in #7987, I’d prefer not to expand it into a broader fallback-layout change unless we can reproduce a real non-structured case in this log view.