-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add SSL configuration options for WebUI and update related logging #5117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
+159
−10
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue (bug_risk): 这里使用
bool(config_value)可能会把非布尔类型的配置值(例如非空字符串)当作启用状态。配置中将
dashboard.ssl.enable标注为布尔值,但这里的代码仍然只是做了一个通用的bool(...)转换。如果该值变成诸如 "false" 或 "0" 之类的非空字符串,它仍然会被评估为True。为了与server.run保持一致并增强健壮性,建议对配置值也复用_parse_env_bool式的逻辑(先规范化字符串并只检查显式的真值),而不是依赖通用的真值判断。Original comment in English
issue (bug_risk): Using
bool(config_value)here may treat non-boolean config values (e.g. non-empty strings) as enabled.Config marks
dashboard.ssl.enableas a bool, but this code still does a genericbool(...)cast. If the value ever becomes a non-empty string like "false" or "0", it will still evaluate toTrue. To align withserver.runand make this robust, consider reusing the same_parse_env_bool-style logic (normalize strings and check explicit truthy values) for the config value instead of relying on general truthiness.