Add a large scale illumination effect #898
Merged
oczoske merged 6 commits intoAstarVienna:mainfrom Apr 15, 2026
Merged
Conversation
…D elliptical Gaussian. , 2. Asymmetric polynomial vignetting with direct falloff control.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
==========================================
+ Coverage 75.11% 75.19% +0.07%
==========================================
Files 69 70 +1
Lines 8953 9013 +60
==========================================
+ Hits 6725 6777 +52
- Misses 2228 2236 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oczoske
reviewed
Apr 3, 2026
oczoske
reviewed
Apr 3, 2026
…made minor changes to the model functions.
oczoske
reviewed
Apr 15, 2026
oczoske
requested changes
Apr 15, 2026
Collaborator
oczoske
left a comment
There was a problem hiding this comment.
Just one request about theta, otherwise that looks fine.
oczoske
requested changes
Apr 15, 2026
oczoske
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 Build in callable models:
Own model input possible
Example:
can be included via
!DET.include_illuminationIncluded Tests in scopesim/tests/tests_effects/test_illumination.py