Add ALS calibration extractor#406
Conversation
| except: | ||
| log.warning("Unable to find ambient light sensor calibration data") | ||
| return | ||
| filename = "apple/aop-als-cal.bin" |
There was a problem hiding this comment.
for my development setup it would be helpful to make the calibration data machine specific. I use an generic initrd with appended kernel modules and a generic vendor firmware cpio. Not sure what would be a good solution for this except retroactively convincing Apple to let iboot insert the calibration data into the ADT.
I might rethink my setup because it's already got annoying when we started to put only the machine specific firmwares into vendorfw.
Apart from that I still see a limited value in making the calibration data machine specific just to make it harder to accidentally use the wrong calibration data and then to complain about bad experience. (not sure how dependent the results are on the calibration data). I'll can take care of the code changes
There was a problem hiding this comment.
i was unable to find an aop key for the serial number of the sensor on the redbird sensors. so, not sure how to match it from the driver there.
There was a problem hiding this comment.
with AsahiLinux/m1n1#548 I have now an alternate way to handle device specific firmware and calibration data
fdcopy is used by more things than just the rootfs image Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
Signed-off-by: Sasha Finkelstein <fnkl.kernel@gmail.com>
2a904ed to
9e26fd7
Compare
Extract ALS calibration, and add an ability to rebuild vendorfw for old installs