Fix New-SignalChart to throw terminating error when Values is null#29
Merged
Fix New-SignalChart to throw terminating error when Values is null#29
Conversation
Merged
Co-authored-by: rebelinux <1002783+rebelinux@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback from review for v0.3.0 public release
Fix New-SignalChart to throw terminating error when Values is null
Mar 14, 2026
|
PSScriptAnalyzer results: Errors: [0], Warnings: [35], Information: [0]
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the New-SignalChart PowerShell cmdlet to emit a terminating error (instead of writing an error string to the pipeline) when -Values is passed as $null, improving error handling behavior for callers and Pester tests.
Changes:
- Replace
WriteObject("Values parameter cannot be null or empty.")withThrowTerminatingError(...)using anErrorRecordandArgumentException.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| { | ||
| WriteObject("Values parameter cannot be null or empty."); | ||
| ThrowTerminatingError(new ErrorRecord( | ||
| new ArgumentException("Values parameter cannot be null or empty."), |
Comment on lines
+274
to
+278
| ThrowTerminatingError(new ErrorRecord( | ||
| new ArgumentException("Values parameter cannot be null or empty."), | ||
| "ValuesNullOrEmpty", | ||
| ErrorCategory.InvalidArgument, | ||
| null)); |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
PSScriptAnalyzer results: Errors: [0], Warnings: [35], Information: [0]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New-SignalChartwas callingWriteObjectwith an error string whenValuesis$null, causingShould -ThrowPester tests to fail and making error handling inconsistent with other cmdlets.Change
Sources/PowerShell/SignalChartPwsh.cs: ReplaceWriteObject("Values parameter cannot be null or empty.")withThrowTerminatingErrorusing anArgumentException, matching the pattern used elsewhere in the codebase.📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.