Log Analysis Introduced with backend_log_extraction.py#1748
Log Analysis Introduced with backend_log_extraction.py#1748OmkarSarkar204 wants to merge 13 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Introduces a new log_analysis module to parse ArduPilot .bin logs, extracting parameter values/defaults, firmware version info, message counts, and frame type, and reuses that logic from extract_param_defaults.py.
Changes:
- Added
log_analysis/backend_log_extraction.pywith log parsing + extraction helpers (params, firmware version, frame type). - Added package initializer
log_analysis/__init__.py. - Refactored
extract_param_defaults.pyto reuse shared validation/version-parsing helpers from the new module.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 10 comments.
| File | Description |
|---|---|
| ardupilot_methodic_configurator/log_analysis/backend_log_extraction.py | New backend log extraction implementation (open/close log, parse messages, extract params/firmware/frame type). |
| ardupilot_methodic_configurator/log_analysis/init.py | Initializes the new log_analysis package with a module docstring. |
| ardupilot_methodic_configurator/extract_param_defaults.py | Replaces in-file regex/version parsing with imports from backend_log_extraction. |
f4b3beb to
b1e5229
Compare
|
The codespell was failing So i just supressed it for now |
c6b4406 to
ace0a54
Compare
Coverage Report for CI Build 28046795869Coverage decreased (-0.7%) to 93.678%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions6 previously-covered lines in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
bdf514b to
4239dca
Compare
f5a17b7 to
9c9ba7c
Compare
9c9ba7c to
d056d57
Compare
|
Thanks for this. I reviewed the code and did some improvements. |
d056d57 to
87d50fa
Compare
I was thinking of adding the test once ive finished the basic signals, but Thank You , Im working on the PM, IMU , VIBE and ERR messages and will try to do it by today midnight. :) |
1e4e8b6 to
2003f98
Compare
|
Extracted till now |
e32105f to
871c7f6
Compare
amilcarlucas
left a comment
There was a problem hiding this comment.
Looks good. By plugins I meant: ARCHITECTURE_battery_monitor.md and ARCHITECTURE_motor_test.md
47ae7f1 to
c70df12
Compare
|
This looks good, we can merge it in. |
… param_default to remove code duplication. Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
c70df12 to
b5312e2
Compare
Thank You! I updated the pr and did some minor commnets changes :) |
4316ac1 to
9ceeb62
Compare
Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
9ceeb62 to
c9fe930
Compare
|
Thank you for the tests i corrected the commit and fixed the ci failures should be passing now |
|
Thanks. I requested a github copilot code review. It that has no findings, we can merge this. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Amilcar Lucas <amilcar.lucas@iav.de>
|
@amilcarlucas , IS this ok, please let me know if any other changes required? |
Signed-off-by: Omkar Sarkar <omkarsarkar24@gmail.com>
76eb9a9 to
b8ed09c
Compare
Description
Pr Introducing the Log_Analysis module for Ardupilot log, which will be used by and with AMC
Checklist
git commit --signoff)Testing
Describe how you tested these changes: