Extract links from HTML5 media tags#394
Open
tsdko wants to merge 3 commits intoArchiveTeam:developfrom
Open
Conversation
Port of wget commit 6a2d67b5836a6f1b9c989968a5392ff3511bc1f9.
Contributor
|
Thanks, looks good to me. The test suite is currently failing miserably though for a variety of reasons, and we need to fix that first (see comments on #393). |
anarcat
approved these changes
Nov 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of mirror/wget@6a2d67b.
I remembered to:
developand set to merge intodevelopChanges:
posterto the list of recognized link attributes andvideo,audioandsourceto the list of recognized tags to extract links from.A few days after making these changes I noticed some of these are actually extracted without being defined there explicitly, not sure if adding them all is a problem. My main reason for making the PR was wpull not downloading files linked in
posterattributes.