Skip to content

Some tweaks in tool docs#847

Open
jottakka wants to merge 4 commits intomainfrom
francisco/some-tweaks-tool-docs
Open

Some tweaks in tool docs#847
jottakka wants to merge 4 commits intomainfrom
francisco/some-tweaks-tool-docs

Conversation

@jottakka
Copy link
Contributor

@jottakka jottakka commented Mar 3, 2026

Note

Medium Risk
Medium risk because it changes how many integration category sidebars are generated and adds a new CI workflow that depends on Engine API secrets; mistakes could break docs navigation or produce noisy/incorrect coverage reporting.

Overview
Adds a new, non-blocking toolkit docs coverage check (check:toolkit-coverage) plus a GitHub Actions workflow to run it on PRs, comparing Engine API toolkits against generated JSON files, index.json, and integration sidebar _meta.tsx entries (with skip lists).

Refactors multiple integration category _meta.tsx files to use a shared createCategoryMeta helper, which auto-inserts Optimized/Starter separators based on toolkit type.

Cleans up generated toolkit data by removing ComplexTools, Deepwiki, and Test2 JSON files, dropping them from data/toolkits/index.json, and adding them to excluded-toolkits.txt so they’re intentionally ignored going forward; includes comprehensive Vitest coverage for the new checker.

Written by Cursor Bugbot for commit a4249fd. This will update automatically on new commits. Configure here.

@vercel
Copy link

vercel bot commented Mar 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Mar 3, 2026 9:17pm

Request Review

@jottakka jottakka self-assigned this Mar 3, 2026
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Unnecessary separator added to single-type categories
    • Modified createCategoryMeta to only emit separators when both Optimized and Starter groups are non-empty, matching the documented behavior.

Create PR

Or push these changes by commenting:

@cursor push 8f1eb8ded9
Preview (8f1eb8ded9)
diff --git a/app/en/resources/integrations/create-category-meta.ts b/app/en/resources/integrations/create-category-meta.ts
--- a/app/en/resources/integrations/create-category-meta.ts
+++ b/app/en/resources/integrations/create-category-meta.ts
@@ -29,16 +29,21 @@
   const starter = entries.filter((e) => e.type === "arcade_starter");
 
   const result: MetaRecord = {};
+  const showSeparators = optimized.length > 0 && starter.length > 0;
 
   if (optimized.length > 0) {
-    result["-- Optimized"] = { type: "separator", title: "Optimized" };
+    if (showSeparators) {
+      result["-- Optimized"] = { type: "separator", title: "Optimized" };
+    }
     for (const entry of optimized) {
       result[entry.slug] = { title: entry.title, href: entry.href };
     }
   }
 
   if (starter.length > 0) {
-    result["-- Starter"] = { type: "separator", title: "Starter" };
+    if (showSeparators) {
+      result["-- Starter"] = { type: "separator", title: "Starter" };
+    }
     for (const entry of starter) {
       result[entry.slug] = { title: entry.title, href: entry.href };
     }
This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Comment on lines +4 to +8
ComplexTools
Deepwiki
Test2
MyServer
Mytest
Copy link
Member

@EricGustin EricGustin Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why were the Test2, DeepWiki, etc. toolkits being pulled from the engine in the first place? Adding these to an exclude list feels like a hack instead of address the root cause, but I could be missing something

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants