Refactor/use new numbuffer in rust 1.98 - #103
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request attempts to replace the external itoa dependency with core::fmt::NumBuffer from the core library to format integers across various reader and block modules. However, core::fmt::NumBuffer is not a valid type in the Rust standard library, and primitive integers do not support the format_into method. To prevent compilation failures, the itoa dependency must be retained, and all changes utilizing NumBuffer and format_into should be reverted back to itoa::Buffer and its format method.
| bytemuck = { version = "1.25.1", features = ["derive", "extern_crate_alloc"] } | ||
| byteorder = "1.5.0" | ||
| itoa = "1.0.18" | ||
| memchr = "2.8.3" |
There was a problem hiding this comment.
The type core::fmt::NumBuffer does not exist in the Rust standard library. We must keep the itoa dependency to format integers without allocation.
| memchr = "2.8.3" | |
| itoa = "1.0.18" | |
| memchr = "2.8.3" |
|
|
||
| // create a reusable buffer for translating record IDs | ||
| let mut translater = itoa::Buffer::new(); | ||
| let mut translater = NumBuffer::new(); |
There was a problem hiding this comment.
Revert to itoa::Buffer::new() as NumBuffer is not a valid standard library type.
| let mut translater = NumBuffer::new(); | |
| let mut translater = itoa::Buffer::new(); |
| for (inner_idx, idx) in (range_start..range_end).enumerate() { | ||
| // translate the index | ||
| let id_str = translater.format(idx); | ||
| let id_str = idx.format_into(&mut translater); |
There was a problem hiding this comment.
Revert to translater.format(idx) since format_into is not a method on primitive integers.
| let id_str = idx.format_into(&mut translater); | |
| let id_str = translater.format(idx); |
| is_paired: self.header.is_paired(), | ||
| has_headers: self.header.has_headers(), | ||
| header_buffer: itoa::Buffer::new(), | ||
| header_buffer: NumBuffer::new(), |
There was a problem hiding this comment.
Revert to itoa::Buffer::new() since NumBuffer is not a valid standard library type.
| header_buffer: NumBuffer::new(), | |
| header_buffer: itoa::Buffer::new(), |
| /// Preallocated itoa buffer for converting global record index to string | ||
| header_buffer: itoa::Buffer, | ||
| /// Preallocated NumBuffer for converting global record index to string | ||
| header_buffer: NumBuffer<usize>, |
There was a problem hiding this comment.
Revert to itoa::Buffer since NumBuffer is not a valid standard library type.
| header_buffer: NumBuffer<usize>, | |
| header_buffer: itoa::Buffer, |
| fn new(index: usize, buf: &mut NumBuffer<usize>) -> Self { | ||
| let mut index_buf = [0u8; 20]; | ||
| let header_str = itoa_buf.format(index); | ||
| let header_str = index.format_into(buf); |
There was a problem hiding this comment.
Revert the signature and implementation to use itoa::Buffer.
| fn new(index: usize, buf: &mut NumBuffer<usize>) -> Self { | |
| let mut index_buf = [0u8; 20]; | |
| let header_str = itoa_buf.format(index); | |
| let header_str = index.format_into(buf); | |
| fn new(index: usize, itoa_buf: &mut itoa::Buffer) -> Self { | |
| let mut index_buf = [0u8; 20]; | |
| let header_str = itoa_buf.format(index); |
| block: &'a RecordBlock, | ||
| pos: usize, | ||
| header_buffer: itoa::Buffer, | ||
| header_buffer: NumBuffer<u64>, |
There was a problem hiding this comment.
Revert to itoa::Buffer since NumBuffer is not a valid standard library type.
| header_buffer: NumBuffer<u64>, | |
| header_buffer: itoa::Buffer, |
| block, | ||
| pos: 0, | ||
| header_buffer: itoa::Buffer::new(), | ||
| header_buffer: NumBuffer::new(), |
There was a problem hiding this comment.
Revert to itoa::Buffer::new() since NumBuffer is not a valid standard library type.
| header_buffer: NumBuffer::new(), | |
| header_buffer: itoa::Buffer::new(), |
| let mut header_len = 0; | ||
| if meta.s_header_span.len == 0 && meta.x_header_span.len == 0 { | ||
| let header_str = self.header_buffer.format(index); | ||
| let header_str = index.format_into(&mut self.header_buffer); |
There was a problem hiding this comment.
Revert to self.header_buffer.format(index) since format_into is not a method on primitive integers.
| let header_str = index.format_into(&mut self.header_buffer); | |
| let header_str = self.header_buffer.format(index); |
1 participant
No description provided.