Skip to content

fix: teleport area from pylons' world and not IO port's (#8675)#8770

Open
ProgramCrafter wants to merge 2 commits intoAppliedEnergistics:mainfrom
ProgramCrafter:patch-1
Open

fix: teleport area from pylons' world and not IO port's (#8675)#8770
ProgramCrafter wants to merge 2 commits intoAppliedEnergistics:mainfrom
ProgramCrafter:patch-1

Conversation

@ProgramCrafter
Copy link
Copy Markdown

No description provided.

@tehgreatdoge
Copy link
Copy Markdown

Have you tested this on a dedicated server? That diff looks sus

@ProgramCrafter
Copy link
Copy Markdown
Author

I have not (yet, though I would be grateful if someone who already has a prepared environment tested it).

The intent is to load ServerLevel from the spatial service, as returned by its implementation

@Override
public ServerLevel getLevel() {
return this.captureLevel;
}
; it will correspond to the pylons rather than the I/O port. Is there any reason why it would not work?

@ProgramCrafter
Copy link
Copy Markdown
Author

Singleplayer test with my fix succeeded. I do not have a dedicated server at hand at the moment, unfortunately.

@HaphLife
Copy link
Copy Markdown

Yay, I'm glad this bug is getting fixed. That looks like the correct approach to me.

The problem was that the teleportation occurred in the dimension of the spatial IO port, rather than the dimension of the pylons, so using the SPS as a proxy of the pylons to replace the spatial IO port looks correct.

SPS determines the value you get by the first pylon on it's internal list, and skips any pylons in other dimensions when determining it's volume, so the dimension should always correspond to the volume it found, and thus be appropriate to use here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants