Skip to content

Fix CPUSelectionList Tooltips.ofBytes(cpu.storage()) and formatStorage#8747

Open
QiuYe-123 wants to merge 2 commits intoAppliedEnergistics:forge/1.20.1from
QiuYe-123:forge/1.20.1
Open

Fix CPUSelectionList Tooltips.ofBytes(cpu.storage()) and formatStorage#8747
QiuYe-123 wants to merge 2 commits intoAppliedEnergistics:forge/1.20.1from
QiuYe-123:forge/1.20.1

Conversation

@QiuYe-123
Copy link
Copy Markdown

Fix the issue where tooltips crash when the CPUSelectionList's cpu capacity is too large, and format the non-tooltips storage capacity numbers into smaller values with the correct units.

@Frostbite-time
Copy link
Copy Markdown

I have a suggestion: could also format CPU co-processor count display in CPUSelectionList? That way, add-ons that introduce CPUs that have many co-processors can show it elegantly without needing a mixin.

@QiuYe-123
Copy link
Copy Markdown
Author

@Frostbite-time Sure, but it's too late. Let's talk about it in the daytime,Because I'm from China

@Frostbite-time
Copy link
Copy Markdown

@Frostbite-time Sure, but it's too late. Let's talk about it in the daytime,Because I'm from China

Between lines 230 and 240 in CPUSelectionList, just need format the coProcessorCount string. However, I’m not this project maintainer, so we can wait for their response first.

@Mithi83
Copy link
Copy Markdown
Collaborator

Mithi83 commented Dec 26, 2025

Reminds me of 92e8dee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants