Skip to content

Suspend and resume crafting jobs#8655

Open
SrNadien wants to merge 2 commits intoAppliedEnergistics:forge/1.20.1from
Divine-Team-By-GalaxyWars:forge/1.20.1
Open

Suspend and resume crafting jobs#8655
SrNadien wants to merge 2 commits intoAppliedEnergistics:forge/1.20.1from
Divine-Team-By-GalaxyWars:forge/1.20.1

Conversation

@SrNadien
Copy link
Copy Markdown

@SrNadien SrNadien commented Sep 6, 2025

Based on #8635 made for the 1.20.1 branch

@SrNadien
Copy link
Copy Markdown
Author

add function

@SrNadien
Copy link
Copy Markdown
Author

works fine

"gui.ae2.StoredPower": "Stored Power: %s",
"gui.ae2.StoredSize": "Stored Size: %dx%dx%d",
"gui.ae2.Stores": "Stores",
"gui.ae2.Substitute": "Using Substitutions:",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this removing a localization entry?

Comment on lines 66 to -67
public CraftingStatus(boolean fullStatus, long elapsedTime, long remainingItemCount, long startItemCount,
List<CraftingStatusEntry> entries) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a delegating constructor to not break addons

Copy link
Copy Markdown
Member

@shartte shartte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my two comments

@SrNadien
Copy link
Copy Markdown
Author

Please see my two comments

Done I compiled it and it works correctly

@shartte
Copy link
Copy Markdown
Member

shartte commented Oct 12, 2025

@SrNadien You have to run the data gen. Do not patch the localization file manually.

@SrNadien
Copy link
Copy Markdown
Author

@SrNadienDebe ejecutar la generación de datos. No modifique el archivo de localización manualmente.

I added it again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants