Skip to content

[Cycode] Fix for SAST detections - Unsanitized external input in SQL query #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cycode-security wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Cycode] Fix for SAST detections - Unsanitized external input in SQL query #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 18 additions & 17 deletions src/main/java/org/owasp/webgoat/lessons/sqlinjection/introduction/SqlInjectionLesson8.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@

/*
* SPDX-FileCopyrightText: Copyright © 2016 WebGoat authors
* SPDX-FileCopyrightText: Copyright 2016 WebGoat authors
* SPDX-License-Identifier: GPL-2.0-or-later
*/
package org.owasp.webgoat.lessons.sqlinjection.introduction;
Expand Down Expand Up @@ -47,19 +48,19 @@ public AttackResult completed(@RequestParam String name, @RequestParam String au
protected AttackResult injectableQueryConfidentiality(String name, String auth_tan) {
StringBuilder output = new StringBuilder();
String query =
"SELECT * FROM employees WHERE last_name = '"
+ name
+ "' AND auth_tan = '"
+ auth_tan
+ "'";
"SELECT * FROM employees WHERE last_name = ? AND auth_tan = ?";

try (Connection connection = dataSource.getConnection()) {
try {
Statement statement =
connection.createStatement(
ResultSet.TYPE_SCROLL_INSENSITIVE, ResultSet.CONCUR_UPDATABLE);
log(connection, query);
ResultSet results = statement.executeQuery(query);
PreparedStatement statement =
connection.prepareStatement(
query,
ResultSet.TYPE_SCROLL_INSENSITIVE,
ResultSet.CONCUR_UPDATABLE);
statement.setString(1, name);
statement.setString(2, auth_tan);
log(connection, name, auth_tan);
ResultSet results = statement.executeQuery();

if (results.getStatement() != null) {
if (results.first()) {
Expand Down Expand Up @@ -128,18 +129,18 @@ public static String generateTable(ResultSet results) throws SQLException {
return (table.toString());
}

public static void log(Connection connection, String action) {
action = action.replace('\'', '"');
public static void log(Connection connection, String name, String auth_tan) {
Calendar cal = Calendar.getInstance();
SimpleDateFormat sdf = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
String time = sdf.format(cal.getTime());

String logQuery =
"INSERT INTO access_log (time, action) VALUES ('" + time + "', '" + action + "')";
"INSERT INTO access_log (time, action) VALUES (?, ?)";

try {
Statement statement = connection.createStatement(TYPE_SCROLL_SENSITIVE, CONCUR_UPDATABLE);
statement.executeUpdate(logQuery);
try (PreparedStatement statement = connection.prepareStatement(logQuery)) {
statement.setString(1, time);
statement.setString(2, "SELECT * FROM employees WHERE last_name = '" + name + "' AND auth_tan = '" + auth_tan + "'");
statement.executeUpdate();
} catch (SQLException e) {
System.err.println(e.getMessage());
}
Expand Down