Skip to content

Remove deleted app from memory #2653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petersohn wants to merge 1 commit into
base: dev
Choose a base branch
from
+3 −3
Open

Remove deleted app from memory #2653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions appdaemon/app_management.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ async def stop_app(self, app_name: str, *, delete: bool = False) -> bool:
bool: Whether stopping was successful or not
"""
try:
if isinstance(self.app_config[app_name], AppConfig):
if isinstance(self.app_config.root.get(app_name), AppConfig):
self.logger.debug("Stopping app '%s'", app_name)
await self.terminate_app(app_name, delete=delete)
except Exception:
Expand Down Expand Up @@ -780,7 +780,7 @@ async def check_app_config_files(self, update_actions: UpdateActions):
) # fmt: skip
update_actions.apps.term |= deleted_apps
for name in deleted_apps:
# del self.app_config.root[name]
self.app_config.root.pop(name, None)
self.logger.info("App config deleted: %s", name)

self.app_config.root.update(freshly_read_cfg.root)
Expand Down Expand Up @@ -1208,7 +1208,7 @@ async def _stop_apps(self, update_actions: UpdateActions):

failed_to_stop = set() # stores apps that had a problem terminating
for app_name in stop_order:
successfully_stopped = await self.stop_app(app_name)
successfully_stopped = await self.stop_app(app_name, delete=True)
if successfully_stopped:
self.logger.info("Stopped app '%s'", app_name)
if app_name in indirect_stops:
Expand Down