Skip to content

fix: small issues #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AntAndriy7 merged 1 commit into from
Jun 18, 2026
Merged

fix: small issues #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions EchoTcpServerTests/UdpTimedSenderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

public class UdpTimedSenderTests
{
private int GetFreeUdpPort()
private static int GetFreeUdpPort()
{
using var udp = new UdpClient(0);
return ((System.Net.IPEndPoint)udp.Client.LocalEndPoint!).Port;
Expand All @@ -34,9 +34,12 @@
var udpReceiveResult = receiveTask.Result;
var bytes = udpReceiveResult.Buffer;

Assert.That(bytes.Length, Is.GreaterThan(0));
Assert.That(bytes[0], Is.EqualTo(0x04));
Assert.That(bytes[1], Is.EqualTo(0x84));
Assert.Multiple(() =>
{
Assert.That(bytes, Has.Length.GreaterThan(0));
Assert.That(bytes[0], Is.EqualTo(0x04));
Assert.That(bytes[1], Is.EqualTo(0x84));
});

Check warning on line 42 in EchoTcpServerTests/UdpTimedSenderTests.cs

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Consider using Assert.EnterMultipleScope statement instead of Assert.Multiple/Assert.MultipleAsync 


See more on https://sonarcloud.io/project/issues?id=AntAndriy7_ReengineeringCourse&issues=AZ7aIwwR6ZOkr7Sa2Fhj&open=AZ7aIwwR6ZOkr7Sa2Fhj&pullRequest=26
}

[Test]
Expand Down
Loading