Fix: add_sig_param: pass annotation to Parameter - #917
Open
RensDimmendaal wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_sig_parambuilds the injectedParameterwithoutannotation=, storing the type only inf.__annotations__. This used to work because fastcore's oldsignature_exmerged__annotations__back over an explicit__signature__, an undocumented side effect of its pre-3.10 backport.The
signature_exrewrite in fastcore delegates to stockinspect.signature, which returns__signature__verbatim. Injected params therefore arrive with no annotation and are ignored by the request machinery. Which explains the failing test in #916Fix: pass
annotation=typwhen constructing the Parameter, putting the type in the signature itself.