Plural lnhash views: lnhashview_files/lnhashview_cells take several targets - #39
Open
ncoop57 wants to merge 5 commits into
Open
Plural lnhash views: lnhashview_files/lnhashview_cells take several targets#39ncoop57 wants to merge 5 commits into
lnhashview_files/lnhashview_cells take several targets#39ncoop57 wants to merge 5 commits into
Conversation
ncoop57
marked this pull request as ready for review
August 2, 2026 22:34
ncoop57
changed the title
lnhashview_files for viewing several files with headerslnhashview_file takes several paths via *args
ncoop57
marked this pull request as draft
August 3, 2026 18:29
ncoop57
changed the title
lnhashview_file takes several paths via *args*args; retire lnhashview_cells
ncoop57
marked this pull request as ready for review
August 3, 2026 18:51
ncoop57
changed the title
*args; retire lnhashview_cellslnhashview_files/lnhashview_cells take several targets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The lnhash views take one or more targets under the plural name, mirroring the fastcore PR (AnswerDotAI/fastcore#887):
lnhashview_files(*paths, ...): several files get# file <path>group headers (the same grammar as multi-targetfile_exhashoutput); a single path renders barelnhashview_cells(path, *cell_ids, ...): same for cells, absorbing the old single-cell form (headers use the resolved cell id)Breaking changes:
lnhashview_fileandlnhashview_cellare renamed to the plurals (no aliases), andstart/endare keyword-only, applied per target. ThelnhashviewCLI has its own argv path and is unaffected.Changes
python/exhash/__init__.py: both views loop their targets; single-target output is unchanged from the old singularspython/exhash/skill.pyandREADME.md: names and docs updated